linux-kernel - Re: [PATCH] objtool: Add machine_real

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180619180140.GA169030@google.com>
Date:   Tue, 19 Jun 2018 11:01:40 -0700
From:   Matthias Kaehlcke <mka@...omium.org>
To:     Josh Poimboeuf <jpoimboe@...hat.com>
Cc:     x86@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] objtool: Add machine_real_restart() to the noreturn list

On Tue, Jun 19, 2018 at 10:47:50AM -0500, Josh Poimboeuf wrote:
> machine_real_restart() is annotated as '__noreturn", so add it to the
> objtool noreturn list.  This fixes the following warning with clang and
> CONFIG_CC_OPTIMIZE_FOR_SIZE=y:
> 
>   arch/x86/kernel/reboot.o: warning: objtool: native_machine_emergency_restart() falls through to next function machine_power_off()
> 
> Reported-by: Matthias Kaehlcke <mka@...omium.org>
> Signed-off-by: Josh Poimboeuf <jpoimboe@...hat.com>

Tested-by: Matthias Kaehlcke <mka@...omium.org>
Reviewed-by: Matthias Kaehlcke <mka@...omium.org>

Thanks!