linux-kernel - Re: [PATCH v2] scsi: cxlflash: Change return type for fault handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180620201237.GA19354@p8tul1-build.aus.stglabs.ibm.com>
Date:   Wed, 20 Jun 2018 15:12:37 -0500
From:   "Matthew R. Ochs" <mrochs@...ux.vnet.ibm.com>
To:     Souptick Joarder <jrdr.linux@...il.com>
Cc:     willy@...radead.org, manoj@...ux.vnet.ibm.com,
        ukrishn@...ux.vnet.ibm.com, jejb@...ux.vnet.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] scsi: cxlflash: Change return type for fault handler

On Wed, Jun 20, 2018 at 11:55:07PM +0530, Souptick Joarder wrote:
> Use new return type vm_fault_t for fault handler. For
> now, this is just documenting that the function returns
> a VM_FAULT value rather than an errno. Once all instances
> are converted, vm_fault_t will become a distinct type.
> 
> Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t")
> 
> Previously, VM_FAULT_NOPAGE was returned without verifying
> return value of vm_insert_pfn. The new inline vmf_insert_pfn()
> will address this issue by returning correct VM_FAULT_* type
> from fault handler.
> 
> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>

Looks good.

Acked-by: Matthew R. Ochs <mrochs@...ux.vnet.ibm.com>