linux-kernel - Re: [PATCH] softirq: reorder trace_softirqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180620202035.GA122295@joelaf.mtv.corp.google.com>
Date:   Wed, 20 Jun 2018 13:20:35 -0700
From:   Joel Fernandes <joel@...lfernandes.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Peter Zilstra <peterz@...radead.org>,
        Joel Fernandes <joelaf@...gle.com>,
        linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...hat.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Thomas Glexiner <tglx@...utronix.de>,
        Boqun Feng <boqun.feng@...il.com>,
        Paul McKenney <paulmck@...ux.vnet.ibm.com>,
        Frederic Weisbecker <fweisbec@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Fenguang Wu <fengguang.wu@...el.com>,
        Baohong Liu <baohong.liu@...el.com>,
        Vedang Patel <vedang.patel@...el.com>, kernel-team@...roid.com
Subject: Re: [PATCH] softirq: reorder trace_softirqs_on to prevent lockdep
 splat

On Wed, Jun 20, 2018 at 04:05:13PM -0400, Steven Rostedt wrote:
> 
> Peter, can you ack this.
> 
> On Thu, 26 Apr 2018 21:11:00 -0700
> Joel Fernandes <joelaf@...gle.com> wrote:
> 
> > I'm able to reproduce a lockdep splat when CONFIG_PROVE_LOCKING=y and
> > CONFIG_PREEMPTIRQ_EVENTS=y.
> > 
> > $ echo 1 > /d/tracing/events/preemptirq/preempt_enable/enable
> > ---
> 
> BTW, the "---" here causes git to ignore everything underneath it :-/

Oh ok, I actually already fixed the '---' issue in the change log since then:

Here's a recent posting of the patch: https://patchwork.kernel.org/patch/10453483/
(patch is the same, only the commit log is fixed to remove '---').

thanks,

- Joel