linux-kernel - Re: [PATCH v3 1/4] mtd: rawnand: marvell: Handle on-die ECC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bf16d760f6a468ebe4417bacc9fc6b4@svr-chch-ex1.atlnz.lc>
Date:   Wed, 20 Jun 2018 21:10:56 +0000
From:   Chris Packham <Chris.Packham@...iedtelesis.co.nz>
To:     Boris Brezillon <boris.brezillon@...tlin.com>
CC:     "miquel.raynal@...tlin.com" <miquel.raynal@...tlin.com>,
        "dwmw2@...radead.org" <dwmw2@...radead.org>,
        "computersforpeace@...il.com" <computersforpeace@...il.com>,
        "linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Richard Weinberger <richard@....at>,
        "Marek Vasut" <marek.vasut@...il.com>
Subject: Re: [PATCH v3 1/4] mtd: rawnand: marvell: Handle on-die ECC

On 20/06/18 19:47, Boris Brezillon wrote:
> Hi Chris,
> 
> On Wed, 20 Jun 2018 17:05:41 +1200
> Chris Packham <chris.packham@...iedtelesis.co.nz> wrote:
> 
>>  From the controllers point of view this is the same as no or
>> software only ECC.
>>
>> Reviewed-by: Boris Brezillon <boris.brezillon@...tlin.com>
> 
> I'm nitpicking, but we usually put the R-b/A-b tags after the author
> SoB.

Yeah sorry force of habit from using gerrit internally. I'll try to 
re-train my fingers.

>> Signed-off-by: Chris Packham <chris.packham@...iedtelesis.co.nz>
>> ---
>> Changes in v2:
>> - New
>> Changes in v3:
>> - Add review from Boris
>>
>>   drivers/mtd/nand/raw/marvell_nand.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c
>> index ebb1d141b900..ba6889bbe802 100644
>> --- a/drivers/mtd/nand/raw/marvell_nand.c
>> +++ b/drivers/mtd/nand/raw/marvell_nand.c
>> @@ -2157,6 +2157,7 @@ static int marvell_nand_ecc_init(struct mtd_info *mtd,
>>   		break;
>>   	case NAND_ECC_NONE:
>>   	case NAND_ECC_SOFT:
>> +	case NAND_ECC_ON_DIE:
>>   		if (!nfc->caps->is_nfcv2 && mtd->writesize != SZ_512 &&
>>   		    mtd->writesize != SZ_2K) {
>>   			dev_err(nfc->dev, "NFCv1 cannot write %d bytes pages\n",
> 
>