linux-kernel - [BUG] usb: xhci: Two possible sleep-in-atomic-context bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <a2f62eac-b3e1-bd1e-3993-83e2f6adef03@gmail.com>
Date:   Wed, 20 Jun 2018 11:12:14 +0800
From:   Jia-Ju Bai <baijiaju1990@...il.com>
To:     mathias.nyman@...el.com, gregkh@...uxfoundation.org
Cc:     linux-usb@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [BUG] usb: xhci: Two possible sleep-in-atomic-context bugs

The driver may sleep with holding a spinlock.
The function call paths (from bottom to top) in Linux-4.16.7 are:

[FUNC] schedule
drivers/base/power/runtime.c, 741: schedule in rpm_resume
drivers/base/power/runtime.c, 1322: rpm_resume in pm_runtime_forbid
drivers/usb/host/xhci-hub.c, 647: pm_runtime_forbid in xhci_enter_test_mode
drivers/usb/host/xhci-hub.c, 632: _raw_spin_lock_irqsave in 
xhci_enter_test_mode

[FUNC] schedule
drivers/base/power/runtime.c, 570: schedule in rpm_suspend
drivers/base/power/runtime.c, 434: rpm_suspend in rpm_idle
drivers/base/power/runtime.c, 1343: rpm_idle in pm_runtime_allow
drivers/usb/host/xhci-hub.c, 670: pm_runtime_allow in xhci_exit_test_mode
drivers/usb/host/xhci-hub.c, 1387: xhci_exit_test_mode in xhci_hub_control
drivers/usb/host/xhci-hub.c, 1038: _raw_spin_lock_irqsave in 
xhci_hub_control

These bugs are found by my static analysis tool (DSAC-2) and checked by my
code review.

I do not know how to correctly fix these bugs, so I just report them.


Best wishes,
Jia-Ju Bai