linux-kernel - Re: [GIT PULL] HID fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nycvar.YFH.7.76.1806200611290.6203@cbobk.fhfr.pm>
Date:   Wed, 20 Jun 2018 06:19:58 +0200 (CEST)
From:   Jiri Kosina <jikos@...nel.org>
To:     Linus Torvalds <torvalds@...ux-foundation.org>
cc:     Julian Sax <jsbc@....de>, Hans de Goede <hdegoede@...hat.com>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] HID fixes

On Wed, 20 Jun 2018, Linus Torvalds wrote:

> What is that odd binary blob i2c_hid_desc_override, and where does the
> data come from? Not explained anywhere.

Fair enough; it's a pretty standard HID descriptor override, but you're 
right that we're usually replacing it in a bit more verbose way. Julian, 
could you please run that descriptor through something like HID descriptor 
tool, and send me a patch that reformats it? (for the way we usually do 
this, look for example in hid-sony.c).

I'll drop this commit and resend the pull request (as namely the steam fix 
really should go in).

The plan eventually is to offload all this crazy rdesc replacing to 
userspace, but that is still WIP.

Thanks,

-- 
Jiri Kosina
SUSE Labs