linux-kernel - Re: [PATCH V9] powercap/drivers/idle_injection: Add an idle injection framework

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180620043415.57yvgzlye4l7wdqy@vireshk-i7>
Date:   Wed, 20 Jun 2018 10:04:15 +0530
From:   Viresh Kumar <viresh.kumar@...aro.org>
To:     Daniel Lezcano <daniel.lezcano@...aro.org>
Cc:     rjw@...ysocki.net, linux-kernel@...r.kernel.org,
        Eduardo Valentin <edubezval@...il.com>,
        Javi Merino <javi.merino@...nel.org>,
        Leo Yan <leo.yan@...aro.org>,
        Kevin Wangtao <kevin.wangtao@...aro.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Rui Zhang <rui.zhang@...el.com>,
        Daniel Thompson <daniel.thompson@...aro.org>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrea Parri <andrea.parri@...rulasolutions.com>,
        "open list:POWER MANAGEMENT CORE" <linux-pm@...r.kernel.org>
Subject: Re: [PATCH V9] powercap/drivers/idle_injection: Add an idle
 injection framework

On 19-06-18, 15:23, Daniel Lezcano wrote:
> Initially, the cpu_cooling device for ARM was changed by adding a new
> policy inserting idle cycles. The intel_powerclamp driver does a
> similar action.
> 
> Instead of implementing idle injections privately in the cpu_cooling
> device, move the idle injection code in a dedicated framework and give
> the opportunity to other frameworks to make use of it.
> 
> The framework relies on the smpboot kthreads which handles via its
> main loop the common code for hotplugging and [un]parking.
> 
> This code was previously tested with the cpu cooling device and went
> through several iterations. It results now in split code and API
> exported in the header file. It was tested with the cpu cooling device
> with success.
> 
> Signed-off-by: Daniel Lezcano <daniel.lezcano@...aro.org>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Eduardo Valentin <edubezval@...il.com>
> Cc: Javi Merino <javi.merino@...nel.org>
> Cc: Leo Yan <leo.yan@...aro.org>
> Cc: Kevin Wangtao <kevin.wangtao@...aro.org>
> Cc: Vincent Guittot <vincent.guittot@...aro.org>
> Cc: Rui Zhang <rui.zhang@...el.com>
> Cc: Daniel Thompson <daniel.thompson@...aro.org>
> Cc: Peter Zijlstra <peterz@...radead.org>
> Cc: Andrea Parri <andrea.parri@...rulasolutions.com>
> ---
> 
> V9:
>    - Unconditionnally reset the should_run flag for all kthreads
>      belonging to the cpumask and remove the park() callback (Viresh Kumar)
>    - Fix up the typos in the comments (Viresh Kumar)

Looks great now. Can't think of any more races :)

Reviewed-by: Viresh Kumar <viresh.kumar@...aro.org>

-- 
viresh