linux-kernel - Re: [PATCH] clk: meson: audio-divider is one based

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8898e54-24b1-ec77-1b08-390607640747@baylibre.com>
Date:   Wed, 20 Jun 2018 10:31:45 +0200
From:   Neil Armstrong <narmstrong@...libre.com>
To:     Jerome Brunet <jbrunet@...libre.com>,
        Kevin Hilman <khilman@...libre.com>,
        Carlo Caione <carlo@...one.org>
Cc:     linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: meson: audio-divider is one based

On 19/06/2018 17:47, Jerome Brunet wrote:
> The audio divider is one based. This offset was mistakenly dropped from
> recalc_rate() when migrating to clk_regmap.
> 
> Fixes: 88a4e1283681 ("clk: meson: migrate the audio divider clock to clk_regmap")
> Signed-off-by: Jerome Brunet <jbrunet@...libre.com>
> ---
>  drivers/clk/meson/clk-audio-divider.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/clk-audio-divider.c b/drivers/clk/meson/clk-audio-divider.c
> index 58f546e04807..e4cf96ba704e 100644
> --- a/drivers/clk/meson/clk-audio-divider.c
> +++ b/drivers/clk/meson/clk-audio-divider.c
> @@ -51,7 +51,7 @@ static unsigned long audio_divider_recalc_rate(struct clk_hw *hw,
>  	struct meson_clk_audio_div_data *adiv = meson_clk_audio_div_data(clk);
>  	unsigned long divider;
>  
> -	divider = meson_parm_read(clk->map, &adiv->div);
> +	divider = meson_parm_read(clk->map, &adiv->div) + 1;
>  
>  	return DIV_ROUND_UP_ULL((u64)parent_rate, divider);
>  }
> 
Acked-by: Neil Armstrong <narmstrong@...libre.com>