linux-kernel - Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1529481910.7211.27.camel@pengutronix.de>
Date:   Wed, 20 Jun 2018 10:05:10 +0200
From:   Lucas Stach <l.stach@...gutronix.de>
To:     Nick Dyer <nick@...anahar.org>, Shawn Guo <shawnguo@...nel.org>
Cc:     Sascha Hauer <s.hauer@...gutronix.de>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Chris Healy <cphealy@...il.com>
Subject: Re: [PATCH v1] ARM: dts: imx51-zii-rdu1: fix touchscreen pinctrl

Hi Nick,

Am Dienstag, den 19.06.2018, 23:07 +0100 schrieb Nick Dyer:
> The pinctrl settings were incorrect for the touchscreen interrupt line, causing
> an interrupt storm. This change has been tested with both the atmel_mxt_ts and
> RMI4 drivers on the RDU1 units.
> 
> > Signed-off-by: Nick Dyer <nick@...anahar.org>
> ---
>  arch/arm/boot/dts/imx51-zii-rdu1.dts | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx51-zii-rdu1.dts b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> index df9eca94d812..4d12ba54ba15 100644
> --- a/arch/arm/boot/dts/imx51-zii-rdu1.dts
> +++ b/arch/arm/boot/dts/imx51-zii-rdu1.dts
> @@ -770,8 +770,8 @@
>  
> >  	pinctrl_ts: tsgrp {
> >  		fsl,pins = <
> > > -			MX51_PAD_CSI1_D8__GPIO3_12		0x85
> > > -			MX51_PAD_CSI1_D9__GPIO3_13		0x85
> > > +			MX51_PAD_CSI1_D8__GPIO3_12		4
> +			MX51_PAD_CSI1_D9__GPIO3_13		(1<<16)

Please don't move away from using hex notation for the padctrl
settings.

Thanks,
Lucas