linux-kernel - Re: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84f8dca3-d1af-5190-270b-5f5319ae4987@geanix.com>
Date:   Wed, 20 Jun 2018 10:40:54 +0200
From:   Martin Hundebøll <martin@...nix.com>
To:     Esben Haabendal <esben.haabendal@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
Cc:     Kurt Kanzenbach <kurt@...utronix.de>,
        Angelo Dureghello <angelo@...am.it>,
        Nikita Yushchenko <nikita.yoush@...entembedded.com>,
        Sanchayan Maity <maitysanchayan@...il.com>,
        Yuan Yao <yao.yuan@....com>, linux-kernel@...r.kernel.org,
        Esben Haabendal <eha@...f.com>
Subject: Re: [PATCH 01/12] spi: spi-fsl-dspi: Drop unreachable else if
 statement



On 2018-06-20 09:34, Esben Haabendal wrote:
> From: Esben Haabendal <eha@...f.com>
> 
> The if statement just above this if/else statement triggers on the same
> condition, and then invalidates it.
> 
> Signed-off-by: Esben Haabendal <eha@...f.com>
> Cc: Martin Hundebøll <martin@...nix.com>

For the entire series:
Acked-by: Martin Hundebøll <martin@...nix.com>

> ---
>   drivers/spi/spi-fsl-dspi.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 0630962ce442..3ca9b9608801 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -593,8 +593,7 @@ static int dspi_eoq_write(struct fsl_dspi *dspi)
>   			dspi_pushr |= SPI_PUSHR_EOQ;
>   			if ((dspi->cs_change) && (!dspi->len))
>   				dspi_pushr &= ~SPI_PUSHR_CONT;
> -		} else if (tx_word && (dspi->len == 1))
> -			dspi_pushr |= SPI_PUSHR_EOQ;
> +		}
>   
>   		regmap_write(dspi->regmap, SPI_PUSHR, dspi_pushr);
>   
> 

-- 
Kind regards,
Martin Hundebøll
Embedded Linux Consultant

+45 61 65 54 61
martin@...nix.com

Geanix IVS
DK39600706