linux-kernel - Re: [PATCH] udf: convert inode stamps to timespec64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180620085835.ei5lhoo3ybmojvhj@quack2.suse.cz>
Date:   Wed, 20 Jun 2018 10:58:35 +0200
From:   Jan Kara <jack@...e.cz>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jan Kara <jack@...e.com>, y2038@...ts.linaro.org,
        Pali Rohár <pali.rohar@...il.com>,
        "Steven J. Magnani" <steve@...idescorp.com>,
        Deepa Dinamani <deepa.kernel@...il.com>,
        Steve Magnani <steve.magnani@...idescorp.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] udf: convert inode stamps to timespec64

Hello,

On Wed 20-06-18 10:15:13, Arnd Bergmann wrote:
> The VFS structures are finally converted to always use 64-bit timestamps,
> and this file system can represent a long range of on-disk timestamps
> already, so now let's fit in the missing bits for udf.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
...
> @@ -70,7 +70,7 @@ udf_disk_stamp_to_time(struct timespec *dest, struct timestamp src)
>  }
>  
>  void
> -udf_time_to_disk_stamp(struct timestamp *dest, struct timespec ts)
> +udf_time_to_disk_stamp(struct timestamp *dest, struct timespec64 ts)
>  {
>  	long seconds;
>  	int16_t offset;

Thanks for the patch! This function needs fixing up as well - 'seconds'
variable needs to be time64_t now. I'll fix it up and take it to my tree.

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR