linux-kernel - Re: [GIT PULL] HID fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b952c1f6-5866-d25e-32c2-ac0ded1812e2@redhat.com>
Date:   Wed, 20 Jun 2018 09:06:08 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Julian Sax <jsbc@....de>
Cc:     Jiri Kosina <jikos@...nel.org>,
        Benjamin Tissoires <benjamin.tissoires@...hat.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [GIT PULL] HID fixes

Hi all,

On 20-06-18 06:19, Jiri Kosina wrote:
> On Wed, 20 Jun 2018, Linus Torvalds wrote:
> 
>> What is that odd binary blob i2c_hid_desc_override, and where does the
>> data come from? Not explained anywhere.
> 
> Fair enough; it's a pretty standard HID descriptor override, but you're
> right that we're usually replacing it in a bit more verbose way. Julian,
> could you please run that descriptor through something like HID descriptor
> tool, and send me a patch that reformats it? (for the way we usually do
> this, look for example in hid-sony.c).

Julian let me know if you need any help with this,
to format the HID descriptor take a file with
the raw descriptor in binary format and do:

cat descriptor.bin | hidrd-convert -o code

I've just done that to make sure my instructions are
right, so to save you having to redo this I've
attached the result.

Regards,

Hans



View attachment "desc.c" of type "text/x-csrc" (18092 bytes)