linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix two possible sleep-in-atomic-context bugs in translate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180620102249.djwmdv34zp5vyj2h@mwanda>
Date:   Wed, 20 Jun 2018 13:22:49 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Jia-Ju Bai <baijiaju1990@...il.com>
Cc:     cocci@...teme.lip6.fr, Julia Lawall <Julia.Lawall@...6.fr>,
        gregkh@...uxfoundation.org, quytelda@...alin.org,
        Larry.Finger@...inger.net, harshasharmaiitr@...il.com,
        arushisinghal19971997@...il.com, amitoj1606@...il.com,
        jeremy.lefaure@....epita.fr, teo.dacquet@...il.com,
        devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Fix two possible
 sleep-in-atomic-context bugs in translate_scan()

On Wed, Jun 20, 2018 at 06:05:06PM +0800, Jia-Ju Bai wrote:
> > Thanks!  It occurs to me that another way to detect this bug is that
> > one of the allocations in this function already uses GFP_ATOMIC.  It
> > doesn't normally make sense to mix GFP_ATOMIC and GFP_KERNEL when there
> > isn't any locking in the function.
> 
> Yes, this pattern is interesting for bug finding :)
> But to fix the bugs of this pattern, we need to decide whether GFP_ATOMIC or
> GFP_KERNEL should be used here.
> 

Sure.  But either way it's a bug. Plus this would be the first static
checker warning which warns about using GFP_ATOMIC when it's supposed to
be GFP_KERNEL.  #milestone

regards,
dan carpenter