linux-kernel - Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180620102841.GJ13316@vkoul-mobl>
Date:   Wed, 20 Jun 2018 15:58:41 +0530
From:   Vinod <vkoul@...nel.org>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Rohit Kumar <rohitkr@...eaurora.org>, lgirdwood@...il.com,
        broonie@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        plai@...eaurora.org, bgoswami@...eaurora.org, perex@...ex.cz,
        tiwai@...e.com, alsa-devel@...a-project.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [alsa-devel] [PATCH] ASoC: qcom: add sdm845 sound card support

On 20-06-18, 10:53, Srinivas Kandagatla wrote:
> On 20/06/18 10:31, Vinod wrote:
> > > Here clock will be enabled twice but disable will be called only once when
> > > count = 0.
> > > 
> > > This will make the clock always enabled. So, I think we should keep either
> > > mutex lock or atomic variable to synchronize this.
> > we are using DPCM here right?
> 
> We should probably model this clk as DAPM widget so we do not need to handle
> this in machine code.

Sure that would be even better, but my point was that we need not worry
about .startup racing in case of DPCM as it holds a card mutex before it
calls PCM ops.. so it is already serialized..

-- 
~Vinod