linux-kernel - Re: [PATCH v10 7/7] x86/tsc: use tsc early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180620103905.s3vmhihbezvkzb5h@shbuild888>
Date:   Wed, 20 Jun 2018 18:39:05 +0800
From:   Feng Tang <feng.tang@...el.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     Pavel Tatashin <pasha.tatashin@...cle.com>,
        steven.sistare@...cle.com, daniel.m.jordan@...cle.com,
        linux@...linux.org.uk, schwidefsky@...ibm.com,
        heiko.carstens@...ibm.com, john.stultz@...aro.org,
        sboyd@...eaurora.org, x86@...nel.org, linux-kernel@...r.kernel.org,
        mingo@...hat.com, hpa@...or.com, douly.fnst@...fujitsu.com,
        peterz@...radead.org, prarit@...hat.com, pmladek@...e.com,
        gnomes@...rguk.ukuu.org.uk
Subject: Re: [PATCH v10 7/7] x86/tsc: use tsc early

On Wed, Jun 20, 2018 at 12:30:58PM +0200, Thomas Gleixner wrote:
> On Wed, 20 Jun 2018, Feng Tang wrote:
> 
> > On Wed, Jun 20, 2018 at 12:16:36PM +0200, Thomas Gleixner wrote:
> > > On Wed, 20 Jun 2018, Feng Tang wrote:
> > > > On Wed, Jun 20, 2018 at 01:52:10AM +0200, Thomas Gleixner wrote:
> > > > >  
> > > > >  static DEFINE_STATIC_KEY_FALSE(__use_tsc);
> > > > > +static DEFINE_STATIC_KEY_TRUE(tsc_early_enabled);
> > > > 
> > > > One potential problem may be the several static_keys used here,
> > > > the "__use_tsc", the "__sched_clock_stable", it may not be used
> > > > very early in boot phase. As the the static_branch_enable() will
> > > > use pageing related code while the paging is not setup ready yet.
> > > 
> > > I know how static keys work and thats the reason for having the extra
> > > conditional. The key is disabled at a point where paging is available.
> > 
> > Maybe I'm wrong, for printk timestamp, it uses the local_clock() thus
> >     sched_clock_cpu()
> > 	sched_clock_stable
> > 	    check the static_key "__sched_clock_stable" which is
> > 	    defined FALSE, and need a static_branch_enable() to
> > 	    take effect
> 
> And that has nothing to do with this particular patch. Please read the rest
> of the series, especially
> 
>    https://lkml.kernel.org/r/20180615174204.30581-5-pasha.tatashin@oracle.com
 
Had not read that patch, thanks for the pointing. No problem now :)

- Feng