linux-kernel - Re: [PATCH] USB: serial: cp210x: Improve baudrate support for CP2102N

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180620105739.GR32411@localhost>
Date:   Wed, 20 Jun 2018 12:57:39 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Karoly Pados <pados@...os.hu>
Cc:     Johan Hovold <johan@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB: serial: cp210x: Improve baudrate support for CP2102N

On Wed, Jun 20, 2018 at 09:51:41AM +0000, Karoly Pados wrote:
> > By the way, have you tried setting other baudrates except the ones you
> > explicitly allow for here? According to the data sheet more rates should
> > be available, so perhaps just handling cp2102n as cp2108 (e.g. by not
> > trying to report back the exact rate used) or by actually calculating
> > the resulting rate could be another option?
> > 
> > Can be done later of course, just curious if you tried it.
> 
> Yeah I know, I was thinking about this too while developing the patch. 
> Officially the cp2102 and the cp2102n are fully software compatible (aside
> from baudrate aliasing), but if the cp2102n chooses different baudrates for 
> the same inputs than the older devices would then they couldn't/wouldn't be
> compatible. So I concluded it must also be doing the quantisation.

Yeah, that's probably right, but the older devices do not support
rates > 1 Mbaud so that logic does not necessarily apply there.

> Maybe I am too naive and trust the datasheet to much. I'll do some
> measurements with my scope and let you know the results.

Cool. We can keep the old behaviour for < 1Mbaud, but it would be nice
to know if you can generate rates other than the 4-5 +1Mbauds rates that
were explicitly mentioned in the data sheet.

Thanks,
Johan