linux-kernel - Re: [PATCH v5 0/9] x86: macrofying inline asm for better compilation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AEBE7B6B-0E78-4018-A347-8DCFE4C60E0D@vmware.com>
Date:   Wed, 20 Jun 2018 16:47:18 +0000
From:   Nadav Amit <namit@...are.com>
To:     Peter Zijlstra <peterz@...radead.org>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Sam Ravnborg <sam@...nborg.org>,
        Alok Kataria <akataria@...are.com>,
        Christopher Li <sparse@...isli.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "H. Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...hat.com>,
        Jan Beulich <JBeulich@...e.com>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Juergen Gross <jgross@...e.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Kees Cook <keescook@...omium.org>,
        "linux-sparse@...r.kernel.org" <linux-sparse@...r.kernel.org>,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        "virtualization@...ts.linux-foundation.org" 
        <virtualization@...ts.linux-foundation.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH v5 0/9] x86: macrofying inline asm for better compilation

at 3:11 AM, Peter Zijlstra <peterz@...radead.org> wrote:

> On Tue, Jun 19, 2018 at 12:48:45PM -0700, Nadav Amit wrote:
>> Nadav Amit (9):
>>  Makefile: Prepare for using macros for inline asm
>>  x86: objtool: use asm macro for better compiler decisions
>>  x86: refcount: prevent gcc distortions
>>  x86: alternatives: macrofy locks for better inlining
>>  x86: bug: prevent gcc distortions
>>  x86: prevent inline distortion by paravirt ops
>>  x86: extable: use macros instead of inline assembly
>>  x86: cpufeature: use macros instead of inline assembly
>>  x86: jump-labels: use macros instead of inline assembly
>> 
>> Makefile                               |  9 ++-
>> arch/x86/Makefile                      | 11 ++-
>> arch/x86/include/asm/alternative-asm.h | 20 ++++--
>> arch/x86/include/asm/alternative.h     | 11 +--
>> arch/x86/include/asm/asm.h             | 61 +++++++---------
>> arch/x86/include/asm/bug.h             | 98 +++++++++++++++-----------
>> arch/x86/include/asm/cpufeature.h      | 82 ++++++++++++---------
>> arch/x86/include/asm/jump_label.h      | 65 ++++++++++-------
>> arch/x86/include/asm/paravirt_types.h  | 56 +++++++--------
>> arch/x86/include/asm/refcount.h        | 74 +++++++++++--------
>> arch/x86/kernel/macros.S               | 16 +++++
>> include/asm-generic/bug.h              |  8 +--
>> include/linux/compiler.h               | 56 +++++++++++----
>> scripts/Kbuild.include                 |  4 +-
>> scripts/mod/Makefile                   |  2 +
>> 15 files changed, 340 insertions(+), 233 deletions(-)
>> create mode 100644 arch/x86/kernel/macros.S
> 
> Aside from the one niggle:
> 
> Acked-by: Peter Zijlstra (Intel) <peterz@...radead.org>

Thanks! I applied your comments for patches 6 & 9. I will send another
version later today.

I have some other patches that address inlining issues and code redundancy
for the alternative mechanism and the RSB stuffing code, but I’ll send them
after this set is applied.

Regards,
Nadav