linux-kernel - Re: [PATCH net][RESEND] strparser: Don't schedule in workqueue in paused state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180620173210.GA6064@davejwatson-mba.local>
Date:   Wed, 20 Jun 2018 10:32:10 -0700
From:   Dave Watson <davejwatson@...com>
To:     Vakul Garg <vakul.garg@....com>
CC:     <davem@...emloft.net>, <doronrk@...com>, <tom@...ntonium.net>,
        <john.fastabend@...il.com>, <netdev@...r.kernel.org>,
        <ebiggers@...gle.com>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net][RESEND] strparser: Don't schedule in workqueue in
 paused state

On 06/21/18 03:29 AM, Vakul Garg wrote:
> In function strp_data_ready(), it is useless to call queue_work if
> the state of strparser is already paused. The state checking should
> be done before calling queue_work. The change reduces the context
> switches and improves the ktls-rx throughput by approx 20% (measured
> on cortex-a53 based platform).

Nice find, works for me. Although current code isn't broken, just
slower, net-next would be fine.

Acked-by: Dave Watson <davejwatson@...com>