[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b22149a1-61dc-82d1-6529-b70575e405c7@redhat.com>
Date: Thu, 21 Jun 2018 11:09:22 +0800
From: Waiman Long <longman@...hat.com>
To: Peter Zijlstra <peterz@...radead.org>
Cc: Tejun Heo <tj@...nel.org>, Li Zefan <lizefan@...wei.com>,
Johannes Weiner <hannes@...xchg.org>,
Ingo Molnar <mingo@...hat.com>, cgroups@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
kernel-team@...com, pjt@...gle.com, luto@...capital.net,
Mike Galbraith <efault@....de>, torvalds@...ux-foundation.org,
Roman Gushchin <guro@...com>,
Juri Lelli <juri.lelli@...hat.com>,
Patrick Bellasi <patrick.bellasi@....com>
Subject: Re: [PATCH v10 5/9] cpuset: Make sure that domain roots work properly
with CPU hotplug
On 06/20/2018 10:15 PM, Peter Zijlstra wrote:
> On Mon, Jun 18, 2018 at 12:14:04PM +0800, Waiman Long wrote:
>> diff --git a/Documentation/admin-guide/cgroup-v2.rst b/Documentation/admin-guide/cgroup-v2.rst
>> index 5ee5e77..6ef3516 100644
>> --- a/Documentation/admin-guide/cgroup-v2.rst
>> +++ b/Documentation/admin-guide/cgroup-v2.rst
>> @@ -1626,6 +1626,13 @@ Cpuset Interface Files
>> 2) No CPU that has been distributed to child scheduling domain
>> roots is deleted.
>>
>> + When all the CPUs allocated to a scheduling domain are offlined,
>> + that scheduling domain will be temporaily gone and all the
>> + tasks in that scheduling domain will migrate to another one that
>> + belongs to the parent of the scheduling domain root. When any
>> + of those offlined CPUs is onlined again, a new scheduling domain
>> + will be re-created and the tasks will be migrated back.
>> +
> You should mention that this is a destructive operation. If any of the
> tasks had an affinity smaller than the original cgroup, that will be
> gone.
Thanks for the information. Will update the documentation to mention that.
Cheers,
Longman
Powered by blists - more mailing lists