linux-kernel - Re: [PATCH 2/7] x86,tlb: leave lazy TLB mode at page table free time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1529540626.7898.178.camel@surriel.com>
Date:   Wed, 20 Jun 2018 20:23:46 -0400
From:   Rik van Riel <riel@...riel.com>
To:     linux-kernel@...r.kernel.org
Cc:     x86@...r.kernel.org, luto@...nel.org, mingo@...nel.org,
        tglx@...utronix.de, dave.hansen@...ux.intel.com, efault@....de,
        songliubraving@...com, kernel-team@...com
Subject: Re: [PATCH 2/7] x86,tlb: leave lazy TLB mode at page table free time

On Wed, 2018-06-20 at 15:56 -0400, Rik van Riel wrote:
> 
> +void tlb_flush_remove_tables(struct mm_struct *mm)
> +{
> +	int cpu = get_cpu();
> +	/*
> +	 * XXX: this really only needs to be called for CPUs in lazy
> TLB mode.
> +	 */
> +	if (cpumask_any_but(mm_cpumask(mm), cpu) < nr_cpu_ids)
> +		smp_call_function_many(mm_cpumask(mm),
> tlb_flush_remove_tables_local, (void *)mm, 1);
> +}
>  

Jens helpfully pointed out I missed a put_cpu().

I have added that in my tree for a v2 of the series.

-- 
All Rights Reversed.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)