linux-kernel - Re: [PATCH] staging: wlan-ng: improved readability of function prism2_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180621082225.xuhqvm7bevbiuaso@mwanda>
Date:   Thu, 21 Jun 2018 11:22:25 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Chris Opperman <eklikeroomys@...il.com>
Cc:     Kate Stewart <kstewart@...uxfoundation.org>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org,
        Philippe Ombredanne <pombredanne@...b.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] staging: wlan-ng: improved readability of function
 prism2_add_key

On Thu, Jun 21, 2018 at 06:42:52AM +0200, Chris Opperman wrote:
> Hi Dan,
> 
> I agree completely. I was concerned whether the preprocessor definitions in
> p80211metadef.h were named according to some convention as there are
> many definitions named similarly there.
> 

Yeah, sure but in that case leave this code alone until we get the time
to update all the definitions.

> I am considering renaming this specific definition to "p80211_dot11_keyid",
> would that be more acceptable?

There is probably a normal define that wireless drivers already use, but
I don't know networking enough to say what it is...  You should try
asking on linux-wireless.

It says in the header that the name is generated automatically?  Is that
true?  How does that work?

Probably it's better to make it upper case?  Are both the P80211 and the
DOT11 required or is DOT11 a subset?  Anyway, I don't think it's
possible to create a worse naming scheme than the driver already has so
I'm likely to approve anything you send.

regards,
dan carpenter