linux-kernel - Re: [PATCH] drivers/i2c: Include SPDX-license-identifier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <331d6408-e61f-6227-da44-0aa26078da0c@axentia.se>
Date:   Thu, 21 Jun 2018 11:45:54 +0200
From:   Peter Rosin <peda@...ntia.se>
To:     Mawanda Henry <mawandahenrynaco@...il.com>, mawanda111@...il.com
Cc:     wsa@...-dreams.de, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers/i2c: Include SPDX-license-identifier

On 2018-06-21 11:40, Mawanda Henry wrote:
> including the SPDX license identifier header  makes it easy for
> developers and machines to know the lecense that is governing the file

If you do changes like this, you should also remove the actual
license text (it follows later in the comment in this case). And
more importantly, you should make *sure* that you use the correct
SPDX tag, which you don't in this case.

So, you need to fix those issues.

Cheers,
Peter

> Signed-off-by: Mawanda Henry <mawandahenrynaco@...il.com>
> ---
>  drivers/i2c/i2c-core-slave.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/i2c/i2c-core-slave.c b/drivers/i2c/i2c-core-slave.c
> index 4a78c65..883ca836 100644
> --- a/drivers/i2c/i2c-core-slave.c
> +++ b/drivers/i2c/i2c-core-slave.c
> @@ -1,3 +1,4 @@
> +// SPDX-License-Identifier: GPL-2.0
>  /*
>   * Linux I2C core slave support code
>   *
>