linux-kernel - Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 04:06:05 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Dmitry Vyukov <dvyukov@...il.com>
Cc:     Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>
Subject: Re: [PATCH] arch/x86: get rid of KERN_CONT in show_fault_oops()

On Wed, Jun 20, 2018 at 3:55 PM, Dmitry Vyukov <dvyukov@...il.com> wrote:
> From: Dmitry Vyukov <dvyukov@...gle.com>
>
> KERN_CONT leads to split lines in kernel output
> and complicates useful changes to printk like
> printing context before each line.
>
> Only acceptable use of continuations is basically
> boot-time testing.
>
> Get rid of it.

> +       printk(KERN_ALERT "BUG: unable to handle kernel %s at %px\n",
> +               (address < PAGE_SIZE ? "NULL pointer dereference" :
> +               "paging request"), (void *) address);

Perhaps pr_alert() ?

Btw, parens are redundant for the first argument.

P.S. And personally I would rather do
if (address < PAGE_SIZE)
 pr_alert(...NULL pointer dereference...);
else
 pr_alert(...paging request...);

-- 
With Best Regards,
Andy Shevchenko