linux-kernel - Re: ThinkPad T480s & LED_MUTE, LED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hzhzojs38.wl-tiwai@suse.de>
Date:   Thu, 21 Jun 2018 13:29:15 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Pali Rohár <pali.rohar@...il.com>
Cc:     Henrique de Moraes Holschuh <ibm-acpi@....eng.br>,
        ibm-acpi-devel@...ts.sourceforge.net,
        platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: ThinkPad T480s & LED_MUTE, LED_MICMUTE

On Thu, 21 Jun 2018 13:24:07 +0200,
Pali Rohár wrote:
> 
> On Tuesday 19 June 2018 10:42:12 Takashi Iwai wrote:
> > On Tue, 19 Jun 2018 10:37:12 +0200,
> > Pali Rohár wrote:
> > > Interesting is this part:
> > > 
> > > $ head /proc/asound/card0/codec#0
> > > Codec: Realtek ALC257
> > > Address: 0
> > > AFG Function Id: 0x1 (unsol 1)
> > > Vendor Id: 0x10ec0257
> > > Subsystem Id: 0x17aa2258
> > > Revision Id: 0x100001
> > > No Modem Function Group found
> > > Default PCM:
> > >     rates [0x560]: 44100 48000 96000 192000
> > >         bits [0xe]: 16 20 24
> > > 
> > > It uses vendor id 0x10ec0257 and support for it was added into
> > > snd-hda-codec-realtek in commit f429e7e494 which was introduced in
> > > version v4.15.
> > > 
> > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=f429e7e494afaded76e62c6f98211a635aa03098
> > > 
> > > I applied this patch to Debian's 4.9 kernel and mute & mic mute leds
> > > started working. This one patch was enough.
> > > 
> > > Takashi, it is possible to backport this patch into -stable trees?
> > 
> > It has already a Cc-to-stable, so it should have been backported.
> > Maybe it wasn't applicable at that time due to lack of other dependent
> > patches...
> > 
> > In anyway, feel free to ping Greg for including it to 4.9.x if it
> > works for you now.
> 
> I sent email to Greg, but it was eaten by "email-bot of Greg
> Kroah-Hartman's inbox". So I sent another patch email to stable ML.

Better to put '[PATCH 4.9.y]' prefix in the subject to make clear that
it's only for 4.9.y.

Also, the line indicating the upstream commit id is:

  commit $ID upstream.

Last but not least, if you resubmit the patch, you must give your own
sign-off, too.


thanks,

Takashi