linux-kernel - [PATCH] fman: don't set node on dpaa-ethernet platform device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180621114222.8326-1-bas@daedalean.ai>
Date:   Thu, 21 Jun 2018 13:42:22 +0200
From:   Bas Vermeulen <bas@...dalean.ai>
To:     netdev@...r.kernel.org
Cc:     bas@...dalean.ai, Madalin Bucur <madalin.bucur@....com>,
        linux-kernel@...r.kernel.org
Subject: [PATCH] fman: don't set node on dpaa-ethernet platform device

Setting dev->node to the mac_node in dpaa_eth_add_device during probe
causes the mac_probe to be called again for the dpaa-ethernet.* device
that was just added.

Fix this by not setting dev->node, as it is not needed.

Signed-off-by: Bas Vermeulen <bas@...dalean.ai>
---
 drivers/net/ethernet/freescale/fman/mac.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/fman/mac.c b/drivers/net/ethernet/freescale/fman/mac.c
index 387eb4a88b72..9a265f862065 100644
--- a/drivers/net/ethernet/freescale/fman/mac.c
+++ b/drivers/net/ethernet/freescale/fman/mac.c
@@ -623,7 +623,6 @@ static struct platform_device *dpaa_eth_add_device(int fman_id,
 		goto no_mem;
 	}
 
-	pdev->dev.of_node = node;
 	pdev->dev.parent = priv->dev;
 	set_dma_ops(&pdev->dev, get_dma_ops(priv->dev));
 
-- 
2.17.1