linux-kernel - Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from BIT STRING

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LRH.2.21.1806211144140.30225@namei.org>
Date:   Thu, 21 Jun 2018 11:44:29 +1000 (AEST)
From:   James Morris <jmorris@...ei.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
cc:     "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>,
        David Howells <dhowells@...hat.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Gary Hook <gary.hook@....com>,
        "David S. Miller" <davem@...emloft.net>,
        james.morris@...rosoft.com, "Serge E. Hallyn" <serge@...lyn.com>,
        keyrings@...r.kernel.org, linux-security-module@...r.kernel.org,
        linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2][RESEND] X.509: unpack RSA signatureValue field from
 BIT STRING

On Wed, 20 Jun 2018, Herbert Xu wrote:

> On Wed, Jun 20, 2018 at 02:24:54PM +0200, Maciej S. Szmigiero wrote:
> > 
> > A friendly ping here.
> > 
> > @AMD people:
> > Without this patch, in-kernel X.509 certificate verification is broken
> > on AMD CCP RSA implementation.
> > 
> > For example, loading wireless regulatory database gives the following
> > errors:
> > > [   21.310361] cfg80211: Problem loading in-kernel X.509 certificate (-22)
> > > [   21.351717] cfg80211: loaded regulatory.db is malformed or signature is missing/invalid
> > 
> > Kernel modules signature verification probably has similar problem, too.
> > 
> > That's why it would be nice if you could ack this patch, please.
> 
> David/James, is there an issue with the patch?

Not from my POV.

-- 
James Morris
<jmorris@...ei.org>