linux-kernel - Re: [PATCH 4/5] ceph: use timespec64 for r

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 16:57:16 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     "Yan, Zheng" <ukernel@...il.com>
Cc:     Zheng Yan <zyan@...hat.com>, Sage Weil <sage@...hat.com>,
        Ilya Dryomov <idryomov@...il.com>,
        Alex Elder <elder@...nel.org>,
        y2038 Mailman List <y2038@...ts.linaro.org>,
        ceph-devel <ceph-devel@...r.kernel.org>,
        Jens Axboe <axboe@...nel.dk>,
        David Miller <davem@...emloft.net>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Jason Dillaman <dillaman@...hat.com>,
        daniel.m.jordan@...cle.com, Jan Kara <jack@...e.cz>,
        linux-block <linux-block@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Networking <netdev@...r.kernel.org>
Subject: Re: [PATCH 4/5] ceph: use timespec64 for r_mtime

On Thu, Jun 21, 2018 at 2:41 PM, Yan, Zheng <ukernel@...il.com> wrote:
> On Wed, Jun 20, 2018 at 11:55 PM Arnd Bergmann <arnd@...db.de> wrote:

>> @@ -1013,7 +1013,7 @@ ceph_direct_read_write(struct kiocb *iocb, struct iov_iter *iter,
>>                         truncate_inode_pages_range(inode->i_mapping, pos,
>>                                         (pos+len) | (PAGE_SIZE - 1));
>>
>> -                       req->r_mtime = mtime;
>> +                       req->r_mtime = current_time(inode);
> this change is not needed

Good catch, no idea how those two changes ended up in here, I'll
resend without them.

Thanks,

      Arnd