linux-kernel - Re: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <878t78i2h6.fsf@gmail.com>
Date:   Thu, 21 Jun 2018 17:27:49 +0200
From:   Esben Haabendal <esben.haabendal@...il.com>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] spi: spi-fsl-dspi: Fix copy-paste error in dspi_probe

"Gustavo A. R. Silva" <gustavo@...eddedor.com> writes:

> It seems that the proper structure field to use in this particular
> case is *regmap_pushr* instead of regmap.
>
> Addresses-Coverity-ID: 1470126 ("Copy-paste error")
> Fixes: 58ba07ec79e6 ("spi: spi-fsl-dspi: Add support for XSPI mode registers")
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  drivers/spi/spi-fsl-dspi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c
> index 1f85dcd..ff7456b 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -1066,7 +1066,7 @@ static int dspi_probe(struct platform_device *pdev)
>  			dev_err(&pdev->dev,
>  				"failed to init pushr regmap: %ld\n",
>  				PTR_ERR(dspi->regmap_pushr));
> -			ret = PTR_ERR(dspi->regmap);
> +			ret = PTR_ERR(dspi->regmap_pushr);
>  			goto out_master_put;
>  		}
>  	}

Acked-by: Esben Haabendal <eha@...f.com>