linux-kernel - Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 21 Jun 2018 17:07:37 +0100
From:   Stefan Hajnoczi <stefanha@...hat.com>
To:     Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
Cc:     davem@...emloft.net, jhansen@...are.com, cavery@...hat.com,
        borntraeger@...ibm.com, fiuczy@...ux.ibm.com,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v1 1/1] VSOCK: fix loopback on big-endian systems

On Wed, Jun 20, 2018 at 03:51:51PM +0200, Claudio Imbrenda wrote:
> The dst_cid and src_cid are 64 bits, therefore 64 bit accessors should be
> used, and in fact in virtio_transport_common.c only 64 bit accessors are
> used. Using 32 bit accessors for 64 bit values breaks big endian systems.
> 
> This patch fixes a wrong use of le32_to_cpu in virtio_transport_send_pkt.
> 
> Fixes: b9116823189e85ccf384 ("VSOCK: add loopback to virtio_transport")
> 
> Signed-off-by: Claudio Imbrenda <imbrenda@...ux.vnet.ibm.com>
> ---
>  net/vmw_vsock/virtio_transport.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefan Hajnoczi <stefanha@...hat.com>

Download attachment "signature.asc" of type "application/pgp-signature" (456 bytes)