linux-kernel - Re: [PATCH v3] tpm: Return the actual size when receiving an unsupported command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180621164925.GF11859@linux.intel.com>
Date:   Thu, 21 Jun 2018 19:49:25 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Ricardo Schwarzmeier <Ricardo.Schwarzmeier@...ineon.com>
Cc:     linux-integrity@...r.kernel.org, linux-kernel@...r.kernel.org,
        peterhuewe@....de, jgg@...pe.ca, arnd@...db.de,
        gregkh@...uxfoundation.org
Subject: Re: [PATCH v3] tpm: Return the actual size when receiving an
 unsupported command

On Wed, Jun 20, 2018 at 04:38:23PM +0200, Ricardo Schwarzmeier wrote:
> The userpace expects to read the number of bytes stated in the header.
> Returning the size of the buffer instead would be unexpected.
> 
> Fixes: 095531f891e6 ("tpm: return a TPM_RC_COMMAND_CODE response if command is not implemented")
> 

No empty line here.

> Signed-off-by: Ricardo Schwarzmeier <Ricardo.Schwarzmeier@...ineon.com>
> ---
> Changes since v2:
>  * Made commit message more clear
>  * Avoided endianness problems
> ---

The change log hould be here in order not to be included as part of
the commit message.

/Jarkko