[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <187d0436-0b04-dd9e-98bd-3cb812fa8bd6@ti.com>
Date: Thu, 21 Jun 2018 12:22:32 -0500
From: Grygorii Strashko <grygorii.strashko@...com>
To: Colin King <colin.king@...onical.com>,
"David S . Miller" <davem@...emloft.net>,
Florian Fainelli <f.fainelli@...il.com>,
Ivan Khoronzhuk <ivan.khoronzhuk@...aro.org>,
<linux-omap@...r.kernel.org>, <netdev@...r.kernel.org>,
<netdev@...r.kernel.org>
CC: <kernel-janitors@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net: ethernet: ti: davinci_cpdma: make function
cpdma_desc_pool_create static
Please, add netdev@...r.kernel.org for the future
On 06/21/2018 12:16 PM, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
>
> The function cpdma_desc_pool_create is local to the source and does not
> need to be in global scope, so make it static.
>
> Cleans up sparse warning:
> warning: symbol 'cpdma_desc_pool_create' was not declared. Should it
> be static?
>
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
> drivers/net/ethernet/ti/davinci_cpdma.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/ti/davinci_cpdma.c b/drivers/net/ethernet/ti/davinci_cpdma.c
> index cdbddf16dd29..4f1267477aa4 100644
> --- a/drivers/net/ethernet/ti/davinci_cpdma.c
> +++ b/drivers/net/ethernet/ti/davinci_cpdma.c
> @@ -205,7 +205,7 @@ static void cpdma_desc_pool_destroy(struct cpdma_ctlr *ctlr)
> * devices (e.g. cpsw switches) use plain old memory. Descriptor pools
> * abstract out these details
> */
> -int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
> +static int cpdma_desc_pool_create(struct cpdma_ctlr *ctlr)
> {
> struct cpdma_params *cpdma_params = &ctlr->params;
> struct cpdma_desc_pool *pool;
>
Reviewed-by: Grygorii Strashko <grygorii.strashko@...com>
--
regards,
-grygorii
Powered by blists - more mailing lists