linux-kernel - Re: [PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecdf3bdf-6453-0c5f-1a72-b4df7148c867@linux-m68k.org>
Date:   Fri, 22 Jun 2018 10:19:53 +1000
From:   Greg Ungerer <gerg@...ux-m68k.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     linux-m68k@...ts.linux-m68k.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] m68knommu: Fix typos in Coldfire 5272 DMA debug code

Hi Geert,

On 22/06/18 06:30, Geert Uytterhoeven wrote:
> If DEBUG_DMA is defined:
> 
>      include/asm/dma.h: In function ‘set_dma_mode’:
>      include/asm/dma.h:393: error: ‘dmabp’ undeclared (first use in this function)
>      include/asm/dma.h:393: error: (Each undeclared identifier is reported only once
>      include/asm/dma.h:393: error: for each function it appears in.)
>      include/asm/dma.h: In function ‘set_dma_addr’:
>      include/asm/dma.h:424: error: ‘dmawp’ undeclared (first use in this function)
> 
> Reported-by: kbuild test robot <fengguang.wu@...el.com>
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Acked-by: Greg Ungerer <gerg@...ux-m68k.org>

Do you want me to take this via the m68knommu git tree?

Regards
Greg


> ---
> v2:
>    - Add Acked-by.
> ---
>   arch/m68k/include/asm/dma.h | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/m68k/include/asm/dma.h b/arch/m68k/include/asm/dma.h
> index b0978a23bad1d7ee..ae2021964e32d36f 100644
> --- a/arch/m68k/include/asm/dma.h
> +++ b/arch/m68k/include/asm/dma.h
> @@ -390,7 +390,7 @@ static __inline__ void set_dma_mode(unsigned int dmanr, char mode)
>   
>   #ifdef DEBUG_DMA
>     printk("%s(%d): dmanr=%d DMR[%x]=%x DIR[%x]=%x\n", __FILE__, __LINE__,
> -         dmanr, (int) &dmalp[MCFDMA_DMR], dmabp[MCFDMA_DMR],
> +	 dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
>   	 (int) &dmawp[MCFDMA_DIR], dmawp[MCFDMA_DIR]);
>   #endif
>   }
> @@ -421,7 +421,7 @@ static __inline__ void set_dma_addr(unsigned int dmanr, unsigned int a)
>   
>   #ifdef DEBUG_DMA
>     printk("%s(%d): dmanr=%d DMR[%x]=%x SAR[%x]=%08x DAR[%x]=%08x\n",
> -	__FILE__, __LINE__, dmanr, (int) &dmawp[MCFDMA_DMR], dmawp[MCFDMA_DMR],
> +	__FILE__, __LINE__, dmanr, (int) &dmalp[MCFDMA_DMR], dmalp[MCFDMA_DMR],
>   	(int) &dmalp[MCFDMA_DSAR], dmalp[MCFDMA_DSAR],
>   	(int) &dmalp[MCFDMA_DDAR], dmalp[MCFDMA_DDAR]);
>   #endif
>