linux-kernel - Re: [PATCH] perf/core: Move the inline keyword at the beginning of function declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+7wUswY+W1x0DeBHaproaKicWON7hSxNUMXgOcO_4NsFdJEsQ@mail.gmail.com>
Date:   Fri, 22 Jun 2018 09:22:51 +0200
From:   Mathieu Malaterre <malat@...ian.org>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     trival@...nel.org, Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf/core: Move the inline keyword at the beginning of
 function declaration

ping ?
On Thu, Mar 8, 2018 at 9:29 PM Mathieu Malaterre <malat@...ian.org> wrote:
>
> The inline keyword was not at the beginning of the function declaration.
> Fix the following warning (reported at W=1)
>
>   CC      kernel/events/ring_buffer.o
> kernel/events/ring_buffer.c:105:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static bool __always_inline
>  ^~~~~~
> kernel/events/ring_buffer.c:116:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static int __always_inline
>  ^~~~~~
> kernel/events/ring_buffer.c:416:1: warning: ‘inline’ is not at beginning of declaration [-Wold-style-declaration]
>  static bool __always_inline rb_need_aux_wakeup(struct ring_buffer *rb)
>  ^~~~~~
>   AR      kernel/events/built-in.o
>
> Signed-off-by: Mathieu Malaterre <malat@...ian.org>
> ---
>  kernel/events/ring_buffer.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/events/ring_buffer.c b/kernel/events/ring_buffer.c
> index 6c6b3c48db71..03e39e3df543 100644
> --- a/kernel/events/ring_buffer.c
> +++ b/kernel/events/ring_buffer.c
> @@ -102,7 +102,7 @@ static void perf_output_put_handle(struct perf_output_handle *handle)
>         preempt_enable();
>  }
>
> -static bool __always_inline
> +static __always_inline bool
>  ring_buffer_has_space(unsigned long head, unsigned long tail,
>                       unsigned long data_size, unsigned int size,
>                       bool backward)
> @@ -113,7 +113,7 @@ ring_buffer_has_space(unsigned long head, unsigned long tail,
>                 return CIRC_SPACE(tail, head, data_size) >= size;
>  }
>
> -static int __always_inline
> +static __always_inline int
>  __perf_output_begin(struct perf_output_handle *handle,
>                     struct perf_event *event, unsigned int size,
>                     bool backward)
> @@ -413,7 +413,7 @@ void *perf_aux_output_begin(struct perf_output_handle *handle,
>  }
>  EXPORT_SYMBOL_GPL(perf_aux_output_begin);
>
> -static bool __always_inline rb_need_aux_wakeup(struct ring_buffer *rb)
> +static __always_inline bool rb_need_aux_wakeup(struct ring_buffer *rb)
>  {
>         if (rb->aux_overwrite)
>                 return false;
> --
> 2.11.0
>