linux-kernel - Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a07b99f8-e5ea-fa8c-dc43-75c032c4afd0@daenzer.net>
Date:   Fri, 22 Jun 2018 09:38:30 +0200
From:   Michel Dänzer <michel@...nzer.net>
To:     Lyude Paul <lyude@...hat.com>
Cc:     amd-gfx@...ts.freedesktop.org,
        "David (ChunMing) Zhou" <David1.Zhou@....com>,
        Andrey Grodzovsky <andrey.grodzovsky@....com>,
        David Airlie <airlied@...ux.ie>,
        Tony Cheng <Tony.Cheng@....com>, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Shirish S <shirish.s@....com>,
        "Leo (Sunpeng) Li" <sunpeng.li@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Harry Wentland <harry.wentland@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: Count disabled CRTCs in commit tail earlier

On 2018-06-21 10:48 PM, Lyude Paul wrote:
> This fixes a regression I accidentally reduced that was picked up by
> kasan, where we were checking the CRTC atomic states after DRM's helpers
> had already freed them. Example:
> 
> [...]
> 
> So, we fix this by counting the number of CRTCs this atomic commit disabled
> early on in the function before their atomic states have been freed, then use
> that count later to do the appropriate number of RPM puts at the end of the
> function.
> 
> Fixes: 97028037a38ae ("drm/amdgpu: Grab/put runtime PM references in atomic_commit_tail()")
> Signed-off-by: Lyude Paul <lyude@...hat.com>
> Cc: Michel Dänzer <michel@...nzer.net>
> Reported-by: Michel Dänzer <michel@...nzer.net>

Actually, it was reported by Tom St Denis <tom.stdenis@....com>. With
that fixed,

Acked-by: Michel Dänzer <michel.daenzer@....com>

(needs review by DC folks)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer