linux-kernel - Re: [PATCH] f2fs: assign REQ_RAHEAD to bio for ->readpages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ce9fb180-2458-4c50-9cee-cfe1bfc3a201@huawei.com>
Date:   Fri, 22 Jun 2018 15:38:41 +0800
From:   Chao Yu <yuchao0@...wei.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>, <linux-kernel@...r.kernel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>
CC:     Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] f2fs: assign REQ_RAHEAD to bio for ->readpages

On 2018/6/22 3:32, Jaegeuk Kim wrote:
> As Jens reported, we'd better assign REQ_RAHEAD to bio by the fact that
> ->readpages is called only from read-ahead.
> 
> In Documentation/filesystems/vfs.txt,
> 
> readpages: called by the VM to read pages associated with the address_space
>   	object. This is essentially just a vector version of
>   	readpage.  Instead of just one page, several pages are
>   	requested.
> 	readpages is only used for read-ahead, so read errors are
>   	ignored.  If anything goes wrong, feel free to give up.
> 
> Signed-off-by: Jens Axboe <axboe@...nel.dk>
> Signed-off-by: Jaegeuk Kim <jaegeuk@...nel.org>

Reviewed-by: Chao Yu <yuchao0@...wei.com>

Thanks,