linux-kernel - Re: [PATCH 5/7] dt-bindings: samsung: Document bindings for Samsung aries boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJKOXPdV+UKKnntcrXQ15aOB5eCehyxqVEJfvZp5faTw434rPw@mail.gmail.com>
Date:   Fri, 22 Jun 2018 09:56:41 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
Cc:     kgene@...nel.org, robh+dt@...nel.org, mark.rutland@....com,
        linux@...linux.org.uk, linux-arm-kernel@...ts.infradead.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, xc-racer2@...e.ca
Subject: Re: [PATCH 5/7] dt-bindings: samsung: Document bindings for Samsung
 aries boards

On 21 June 2018 at 21:09, Paweł Chmiel <pawel.mikolaj.chmiel@...il.com> wrote:
> Signed-off-by: Paweł Chmiel <pawel.mikolaj.chmiel@...il.com>
> ---
>  Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> index 14510b215480..edce6602de50 100644
> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt
> @@ -2,6 +2,8 @@
>
>  Required root node properties:
>      - compatible = should be one or more of the following.
> +       - "samsung,aries"       - for S5PV210-based Samsung Aries board.
> +       - "samsung,galaxys"     - for S5PV210-based Samsung Galaxy S (i9000)  board.

It is not strictly speaking Exynos-based board (as mentioned in the
header at beginning of file) so maybe change it to "Samsung's Exynos
and S5P SoC based boards"?

Best regards,
Krzysztof

>         - "samsung,artik5"      - for Exynos3250-based Samsung ARTIK5 module.
>         - "samsung,artik5-eval" - for Exynos3250-based Samsung ARTIK5 eval board.
>         - "samsung,monk"        - for Exynos3250-based Samsung Simband board.
> --
> 2.7.4
>