linux-kernel - Re: [PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAB0TPYGfE6p-avP1BknP62EHz=yCXfRytzd_isuVBmSX5tZ+Kw@mail.gmail.com>
Date:   Fri, 22 Jun 2018 10:48:56 +0200
From:   Martijn Coenen <maco@...roid.com>
To:     Joel Fernandes <joel@...lfernandes.org>
Cc:     Daniel Colascione <dancol@...gle.com>,
        Alistair Strachan <astrachan@...gle.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Arve Hjønnevåg <arve@...roid.com>,
        Todd Kjos <tkjos@...roid.com>,
        "open list:ANDROID DRIVERS" <devel@...verdev.osuosl.org>,
        kernel-team@...roid.com
Subject: Re: [PATCH 2/2 v2] staging: android: ashmem: Fix mmap size validation

On Thu, Jun 21, 2018 at 1:29 AM, Joel Fernandes <joel@...lfernandes.org> wrote:
> Also if you look at the kernel sources, there are dozens of drivers that
> check for correct VMA size in mmap handler and fail if it isn't sized
> correctly.

If that's the case, we should definitely do it this way for ashmem as
well. Since its size is fixed after creation, preventing anyone from
mapping a larger size seems reasonable to me.

Reviewed-by: Martijn Coenen <maco@...roid.com>

>
> thanks!
>
>  - Joel
>