linux-kernel - Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY and MUIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJKOXPeyh=oGE90Uz9nMxd-JgNORmoG3xPcMSHUrbnjccu5U2g@mail.gmail.com>
Date:   Fri, 22 Jun 2018 12:56:25 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Andrzej Hajda <a.hajda@...sung.com>
Cc:     "open list:DESIGNWARE USB3 DRD IP DRIVER" <linux-usb@...r.kernel.org>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Inki Dae <inki.dae@...sung.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
        linux-kernel@...r.kernel.org,
        "linux-samsung-soc@...r.kernel.org" 
        <linux-samsung-soc@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] arm64: dts: exynos: add OF graph between USB-PHY
 and MUIC

On 22 June 2018 at 12:39, Andrzej Hajda <a.hajda@...sung.com> wrote:
> On 20.06.2018 20:28, Krzysztof Kozlowski wrote:
>> On Tue, May 15, 2018 at 02:12:39PM +0200, Andrzej Hajda wrote:
>>> OF graph describes USB data lanes between USB-PHY and respective MUIC.
>>> Since graph is present and DWC driver can use it to get extcon, obsolete
>>> extcon property can be removed.
>>>
>>> Signed-off-by: Andrzej Hajda <a.hajda@...sung.com>
>>> ---
>>>  .../dts/exynos/exynos5433-tm2-common.dtsi     | 19 ++++++++++++++++++-
>>>  1 file changed, 18 insertions(+), 1 deletion(-)
>> dtc W=1 now complains with:
>> ===
>> Warning (graph_child_address):
>> /soc/hsi2c@...90000/max77843@...max77843-muic/ports: graph node has single child node 'port@0', #address-cells/#size-cells are not necessary
>> ===
>>
>> Do you plan to add more ports soon?
>
> There could be a link between UART and MUIC, it could be beneficial for
> the platform - there is no point to feed UART with data when UART output
> is muxed-out by MUIC.
> So I plan to investigate it but this is not on my short list :)
> Alternatively one can create graphs without using it atm.

In that case could you remove here the address/size-cells to fix the
warning? I see that code uses -1 in of_graph_get_remote_node() so it
should not depend on the reg number.

Best regards,
Krzysztof