linux-kernel - [PATCH] [v3] reiserfs: change j_timestamp type to time64

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20180622133315.221210-1-arnd@arndb.de>
Date:   Fri, 22 Jun 2018 15:32:58 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Andrew Morton <akpm@...ux-foundation.org>
Cc:     y2038@...ts.linaro.org, Arnd Bergmann <arnd@...db.de>,
        Jan Kara <jack@...e.cz>, Jeff Mahoney <jeffm@...e.com>,
        reiserfs-devel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] [v3] reiserfs: change j_timestamp type to time64_t

This uses the deprecated time_t type but is write-only, and could be
removed, but as Jeff explains, having a timestamp can be usefule for
post-mortem analysis in crash dumps.

In order to remove one of the last instances of time_t, this changes
the type to time64_t, same as j_trans_start_time.

Cc: Jan Kara <jack@...e.cz>
Cc: Jeff Mahoney <jeffm@...e.com>
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
This could replace "reiserfs: remove unused j_timestamp" if we decide
that we want to keep that variable.

Posting this patch as an alternative now, while waiting for Jeff to
reply on how important this really is.
---
 fs/reiserfs/reiserfs.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/reiserfs/reiserfs.h b/fs/reiserfs/reiserfs.h
index 621b9a07080a..e5ca9ed79e54 100644
--- a/fs/reiserfs/reiserfs.h
+++ b/fs/reiserfs/reiserfs.h
@@ -271,7 +271,7 @@ struct reiserfs_journal_list {
 
 	struct mutex j_commit_mutex;
 	unsigned int j_trans_id;
-	time_t j_timestamp;
+	time64_t j_timestamp; /* write-only but useful for crash dump analysis */
 	struct reiserfs_list_bitmap *j_list_bitmap;
 	struct buffer_head *j_commit_bh;	/* commit buffer head */
 	struct reiserfs_journal_cnode *j_realblock;
-- 
2.9.0