linux-kernel - Re: [PATCH 3/3] modsign: print module name along with error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180622152836.yxkbhlzpgzlbhgip@linux-5o07>
Date:   Fri, 22 Jun 2018 17:28:36 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     David Howells <dhowells@...hat.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] modsign: print module name along with error message

+++ Jessica Yu [30/05/18 11:08 +0200]:
>It is useful to know which module failed signature verification, so
>print the module name along with the error message.
>
>Signed-off-by: Jessica Yu <jeyu@...nel.org>
>---
> kernel/module.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index ae824a6f1a03..8670585eb5f7 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -2807,7 +2807,7 @@ static int module_sig_check(struct load_info *info, int flags,
> 		reason = "Loading of module with unavailable key";
> 	decide:
> 		if (sig_enforce) {
>-			pr_notice("%s is rejected\n", reason);
>+			pr_notice("%s: %s is rejected\n", info->name, reason);
> 			return -EKEYREJECTED;
> 		}
>

Hi David!

I've just merged patches 1 and 2 into modules-next. Would you be
interested this patch (patch 3) if/when you push lockdown upstream
again?

Thanks!

Jessica