linux-kernel - Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <80C1F514-1B4D-4CDC-BD46-6C3AA9601446@amacapital.net>
Date:   Fri, 22 Jun 2018 09:11:42 -0700
From:   Andy Lutomirski <luto@...capital.net>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     "Chang S. Bae" <chang.seok.bae@...el.com>,
        Andy Lutomirski <luto@...nel.org>,
        "H . Peter Anvin" <hpa@...or.com>, Ingo Molnar <mingo@...nel.org>,
        Andi Kleen <ak@...ux.intel.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Markus T Metzger <markus.t.metzger@...el.com>,
        Ravi Shankar <ravi.v.shankar@...el.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4 7/7] x86/vdso: Move out the CPU number store


> On Jun 22, 2018, at 8:18 AM, Thomas Gleixner <tglx@...utronix.de> wrote:
> 
>> On Wed, 20 Jun 2018, Chang S. Bae wrote:
>> 
>> +#ifdef CONFIG_X86_64
>> +static void setup_cpu_number(int cpu)
> 
> This function name is really misleading. vdso_setup_cpu_and_node() or
> something like that clearly tells what this is about.
> 

Ah. The big secret is that it’s not just vDSO, or at lease hpa wants to start using it in the entry code.

> Thanks,
> 
>    tglx