linux-kernel - Re: [PATCH] soc: qcom: geni: Make version macros simpler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <152968916153.16708.10037419184008772073@swboyd.mtv.corp.google.com>
Date:   Fri, 22 Jun 2018 10:39:21 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Andy Gross <andy.gross@...aro.org>, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Karthikeyan Ramasubramanian <kramasub@...eaurora.org>,
        Sagar Dharia <sdharia@...eaurora.org>,
        Girish Mahadevan <girishm@...eaurora.org>
Subject: Re: [PATCH] soc: qcom: geni: Make version macros simpler

Quoting Bjorn Andersson (2018-06-22 09:54:54)
> On Fri 18 May 15:47 PDT 2018, Stephen Boyd wrote:
> 
> > This macro doesn't work, because it hides a local variable inside of the
> > macro to hold the version and that variable name is called 'ver' and
> > 'version' sometimes.
> > 
> > Let's change this to be more explicit. Introduce three macros for the
> > major, minor, and step of the version, and require callers to pass the
> > version in to get the part of the version out. This way we don't hide
> > local variables inside macros and things are less evil overall.
> > 
> > Cc: Karthikeyan Ramasubramanian <kramasub@...eaurora.org>
> > Cc: Sagar Dharia <sdharia@...eaurora.org>
> > Cc: Girish Mahadevan <girishm@...eaurora.org>
> > Signed-off-by: Stephen Boyd <swboyd@...omium.org>
> 
> I was expecting that someone referenced this macro, but I guess that's
> coming?

The SPI driver does.