linux-kernel - Re: [PATCH] audit: use ktime_get_coarse

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180622202436.tlowdotb2xo4pc6l@madcap2.tricolour.ca>
Date:   Fri, 22 Jun 2018 16:24:36 -0400
From:   Richard Guy Briggs <rgb@...hat.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Kirill Tkhai <ktkhai@...tuozzo.com>,
        Steve Grubb <sgrubb@...hat.com>, linux-audit@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] audit: use ktime_get_coarse_ts64() for time access

On 2018-06-18 16:58, Arnd Bergmann wrote:
> The API got renamed for consistency with the other time accessors,
> this changes the audit caller as well.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This looks reasonable to me.
Not that I think it matters, but any reason it was swapped in a
different code location other than aesthetics?  Time and serial are
usually used together in our code.

Reviewed-by: Richard Guy Briggs <rgb@...hat.com>

> ---
>  kernel/audit.c   | 2 +-
>  kernel/auditsc.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/audit.c b/kernel/audit.c
> index e7478cb58079..3e34b9f03cfe 100644
> --- a/kernel/audit.c
> +++ b/kernel/audit.c
> @@ -1724,7 +1724,7 @@ static inline void audit_get_stamp(struct audit_context *ctx,
>  				   struct timespec64 *t, unsigned int *serial)
>  {
>  	if (!ctx || !auditsc_get_stamp(ctx, t, serial)) {
> -		*t = current_kernel_time64();
> +		ktime_get_coarse_ts64(t);
>  		*serial = audit_serial();
>  	}
>  }
> diff --git a/kernel/auditsc.c b/kernel/auditsc.c
> index ceb1c4596c51..dbbf02f513a8 100644
> --- a/kernel/auditsc.c
> +++ b/kernel/auditsc.c
> @@ -1540,10 +1540,10 @@ void __audit_syscall_entry(int major, unsigned long a1, unsigned long a2,
>  	context->argv[2]    = a3;
>  	context->argv[3]    = a4;
>  	context->serial     = 0;
> -	context->ctime = current_kernel_time64();
>  	context->in_syscall = 1;
>  	context->current_state  = state;
>  	context->ppid       = 0;
> +	ktime_get_coarse_ts64(&context->ctime);
>  }
>  
>  /**
> -- 
> 2.9.0
> 

- RGB

--
Richard Guy Briggs <rgb@...hat.com>
Sr. S/W Engineer, Kernel Security, Base Operating Systems
Remote, Ottawa, Red Hat Canada
IRC: rgb, SunRaycer
Voice: +1.647.777.2635, Internal: (81) 32635