linux-kernel - Re: [PATCH] staging: rtl8723bs: do not use assignment in if condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07e414cea905277f1909d92dab47d3461ea91991.camel@perches.com>
Date:   Fri, 22 Jun 2018 18:59:06 -0700
From:   Joe Perches <joe@...ches.com>
To:     Michael Straube <michael.straube@...teo.de>,
        Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: do not use assignment in if
 condition

On Fri, 2018-06-22 at 21:11 +0200, Michael Straube wrote:
> On 06/22/18 19:28, Joe Perches wrote:
> > Although the last memcpy of a fixed mac address could
> > probably use eth_random_addr to reduce the likelihood
> > of mac address collision so maybe
> > 		eth_random_addr(mac_addr);
> Using a random address would be preffered?

mac address duplication is bad, so if there
were 2 instances of this device on the same
ethernet network, yes.

> 
> Thanks for your help and patience.
> Michael