linux-kernel - Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 24 Jun 2018 08:59:22 -0700
From:   Joe Perches <joe@...ches.com>
To:     John Whitmore <johnfwhitmore@...il.com>,
        linux-kernel@...r.kernel.org
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org
Subject: Re: [PATCH v3 7/8] staging: rtl8192u: Correct if statement - Coding
 Style

On Sun, 2018-06-24 at 16:34 +0100, John Whitmore wrote:
> Corrected the coding style of if statement.
[]
> diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c b/drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c
[]
> @@ -732,7 +732,7 @@ void HTConstructRT2RTAggElement(struct ieee80211_device *ieee, u8 *posRT2RTAgg,
>  	   section of code.
>  	if(IS_UNDER_11N_AES_MODE(Adapter))
>  	{
> -		posRT2RTAgg->Octet[5] |=RT_HT_CAP_USE_AMPDU;
> +		posRT2RTAgg->Octet[5] |= RT_HT_CAP_USE_AMPDU;
>  	}else
>  	{
>  		posRT2RTAgg->Octet[5] &= 0xfb;

Rather than doing individual patches for each line
with a whitespace issue, I think it'd be better to
do a single driver wide patch.

Perhaps use a tool like:

$ git ls-files drivers/staging/rtl8192u |
  xargs ./scripts/checkpatch.pl -f --fix-inplace --types=spacing

where:

$ git diff -w drivers/staging/rtl8192u/

should not show a single difference.

Then compile and commit that as a single patch with
something like "use a more typical spacing style"
as the commit message.