linux-kernel - Re: [PATCH] x86/crypto: Add missing RETs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1806240911520.8650@nanos.tec.linutronix.de>
Date:   Sun, 24 Jun 2018 09:12:35 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Ingo Molnar <mingo@...nel.org>
cc:     Borislav Petkov <bp@...en8.de>, linux-crypto@...r.kernel.org,
        Mike Galbraith <efault@....de>,
        Alexey Dobriyan <adobriyan@...il.com>,
        torvalds@...ux-foundation.org, jpoimboe@...hat.com,
        luto@...nel.org, peterz@...radead.org, brgerst@...il.com,
        hpa@...or.com, linux-kernel@...r.kernel.org, dvlasenk@...hat.com,
        h.peter.anvin@...el.com,
        linux-tip-commits <linux-tip-commits@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] x86/crypto: Add missing RETs

On Sun, 24 Jun 2018, Ingo Molnar wrote:
> * Borislav Petkov <bp@...en8.de> wrote:
> 
> > Lemme send a proper patch now...
> > 
> > ---
> > From: Borislav Petkov <bp@...e.de>
> > Date: Sun, 17 Jun 2018 13:57:42 +0200
> > Subject: [PATCH] x86/crypto: Add missing RETs
> > 
> > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
> > otherwise they run into INT3 padding due to
> > 
> >   51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")
> > 
> > leading to spurious debug exceptions.
> > 
> > Mike Galbraith <efault@....de> took care of all the remaining callsites.
> 
> Note that 51bad67ffbce has been zapped because it caused too many problems like 
> this, but the explicit RETs make sense nevertheless. When applying the patch 
> please don't include the SHA1 of the non-upstream (and probably never-upstream) 
> commit.

We should really have something like that exactly to catch cases like this.

Thanks,

	tglx