linux-kernel - Re: [PATCH v3 2/2] iio: adc: Add Spreadtrum SC27XX PMICs ADC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMz4kuJUeDjTVJqNc4cNv=LwR1HkuFap4vBF7CCcrxNqnTHa-A@mail.gmail.com>
Date:   Sun, 24 Jun 2018 17:13:00 +0800
From:   Baolin Wang <baolin.wang@...aro.org>
To:     Jonathan Cameron <jonathan.cameron@...wei.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        freeman.liu@...eadtrum.com, Mark Brown <broonie@...nel.org>,
        DTML <devicetree@...r.kernel.org>, linux-iio@...r.kernel.org,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 2/2] iio: adc: Add Spreadtrum SC27XX PMICs ADC support

Hi Jonathan,

On 22 June 2018 at 22:13, Jonathan Cameron <jonathan.cameron@...wei.com> wrote:
> On Thu, 21 Jun 2018 11:14:05 +0800
> Baolin Wang <baolin.wang@...aro.org> wrote:
>
>> From: Freeman Liu <freeman.liu@...eadtrum.com>
>>
>> The Spreadtrum SC27XX PMICs ADC controller contains 32 channels,
>> which is used to sample voltages with 12 bits conversion.
>>
>> [Baolin Wang did lots of improvements]
>>
>> Signed-off-by: Freeman Liu <freeman.liu@...eadtrum.com>
>> Signed-off-by: Baolin Wang <baolin.wang@...aro.org>
>
> One trivial missed bit of cleanup inline.  I'll sort that
> when applying if no one else points anything out before I get back to my
> development machine.

Thanks.

>> +
>> +     indio_dev->dev.parent = &pdev->dev;
>> +     indio_dev->name = dev_name(&pdev->dev);
>> +     indio_dev->modes = INDIO_DIRECT_MODE;
>> +     indio_dev->info = &sc27xx_info;
>> +     indio_dev->channels = sc27xx_channels;
>> +     indio_dev->num_channels = ARRAY_SIZE(sc27xx_channels);
>> +     ret = devm_iio_device_register(&pdev->dev, indio_dev);
>> +     if (ret) {
>> +             dev_err(&pdev->dev, "could not register iio (ADC)");
>> +             return ret;
>> +     }
>> +
>> +     platform_set_drvdata(pdev, indio_dev);
>
> Why?  Looks like this is left over from when we had a remove.

Sorry, I missed to remove this redundant code.

-- 
Baolin Wang
Best Regards