linux-kernel - Re: [PATCH] x86/crypto: Add missing RETs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180624104449.GA20159@avx2>
Date:   Sun, 24 Jun 2018 13:44:49 +0300
From:   Alexey Dobriyan <adobriyan@...il.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     Borislav Petkov <bp@...en8.de>, linux-crypto@...r.kernel.org,
        Mike Galbraith <efault@....de>, torvalds@...ux-foundation.org,
        tglx@...utronix.de, jpoimboe@...hat.com, luto@...nel.org,
        peterz@...radead.org, brgerst@...il.com, hpa@...or.com,
        linux-kernel@...r.kernel.org, dvlasenk@...hat.com,
        h.peter.anvin@...el.com,
        linux-tip-commits <linux-tip-commits@...r.kernel.org>,
        Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH] x86/crypto: Add missing RETs

On Sun, Jun 24, 2018 at 09:11:05AM +0200, Ingo Molnar wrote:
> > Add explicit RETs to the tail calls of AEGIS and MORUS crypto algorithms
> > otherwise they run into INT3 padding due to
> > 
> >   51bad67ffbce ("x86/asm: Pad assembly functions with INT3 instructions")
> > 
> > leading to spurious debug exceptions.
> > 
> > Mike Galbraith <efault@....de> took care of all the remaining callsites.
> 
> Note that 51bad67ffbce has been zapped because it caused too many problems like 
> this, but the explicit RETs make sense nevertheless.

So commit which found real bug(s) was zapped.

OK