linux-kernel - Re: [PATCH] usb: xhci: dbc: Don't decrement runtime PM counter if DBC is not started

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <59b5789b-a33d-6a61-af53-dc6feba8951f@linux.intel.com>
Date:   Mon, 25 Jun 2018 11:25:59 +0300
From:   Mathias Nyman <mathias.nyman@...ux.intel.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>,
        mathias.nyman@...el.com
Cc:     gregkh@...uxfoundation.org, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: xhci: dbc: Don't decrement runtime PM counter if DBC
 is not started

On 25.06.2018 08:20, Kai-Heng Feng wrote:
> pm_runtime_put_sync() gets called everytime in xhci_dbc_stop().
> 
> If dbc is not started, this makes the runtime PM counter incorrectly
> becomes 0, and calls autosuspend function. Then we'll keep seeing this:
> [54664.762220] xhci_hcd 0000:00:14.0: Root hub is not suspended
> 
> So only calls pm_runtime_put_sync() when dbc was started.
> 
> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>

Thanks, nice catch.
Adding to queue

-Mathias