linux-kernel - Re: [PATCH] mm/zsmalloc: make several functions and a struct static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180625014709.GC557@jagdpanzerIV>
Date:   Mon, 25 Jun 2018 10:47:09 +0900
From:   Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Minchan Kim <minchan@...nel.org>, Nitin Gupta <ngupta@...are.org>,
        Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
        linux-mm@...ck.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/zsmalloc: make several functions and a struct static

On (06/24/18 22:33), Colin King wrote:
> The functions zs_page_isolate, zs_page_migrate, zs_page_putback,
> lock_zspage, trylock_zspage and structure zsmalloc_aops are local to
> source and do not need to be in global scope, so make them static.
> 
> Cleans up sparse warnings:
> symbol 'zs_page_isolate' was not declared. Should it be static?
> symbol 'zs_page_migrate' was not declared. Should it be static?
> symbol 'zs_page_putback' was not declared. Should it be static?
> symbol 'zsmalloc_aops' was not declared. Should it be static?
> symbol 'lock_zspage' was not declared. Should it be static?
> symbol 'trylock_zspage' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@...il.com>

	-ss